fix(ce-pr-description): mark return block as hand-off#593
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f29755e00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Step 9's return block reads like a terminal output, which caused a caller (git-commit-push-pr) to exit the workflow instead of running the expected gh pr create / gh pr edit. Add one sentence at the end of Step 9 naming the return as a hand-off and directing the agent to continue the parent's remaining steps.
tmchow
force-pushed
the
tmchow/pr-apply-handoff
branch
from
7f29755 to
dff4c5f
Compare
tmchow
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
git-commit-push-prStep 6 delegates toce-pr-description, the sub-skill's Step 9 emits a=== TITLE === / === BODY_FILE ===return block and ends. That return shape reads as a terminal output, so the caller exits the workflow instead of runninggh pr create/gh pr editfrom its own Step 7. Observed in practice while opening #591 — the caller stopped after the return block and the PR never got created.One sentence at the end of
ce-pr-descriptionStep 9 names the return as a hand-off:Two lines added, no other changes. The apply command already exists in
git-commit-push-prStep 7 — the missing piece was a signal at the sub-skill's exit that the return is a hand-off, not a stop.