fix(ce-update): compare against main plugin.json, not release tags#660
Merged
fix(ce-update): compare against main plugin.json, not release tags#660
Conversation
Merged
3 tasks
tmchow
added a commit
that referenced
this pull request
Apr 24, 2026
PR #663 squash-merged as `feat(ce-commit-push-pr):` — adding two short-circuits that skip a blocking prompt when the agent just authored the change. The intent was a UX/flow fix, not a new capability, so the correct conventional prefix is `fix:`. Since the prefix drove a minor bump, the open release PR (#661) is pinning the linked `cli` / `compound-engineering` group at 3.1.0. This empty commit reclassifies the pending release to 3.0.2 via `Release-As:` footers so the patch-level fixes in this window (#660 ce-update, #664 ce-demo-reel, #663 ce-commit-push-pr) land as 3.0.2 instead of 3.1.0. The feat prefix remains in history and may still render under a Features heading in the generated changelog — hand-edit the release PR body before merge if so. Release-As: cli@3.0.2 Release-As: compound-engineering@3.0.2
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/ce-updatepreviously false-flagged every install as "Out of date" whenevermainwas ahead of the latest release tag (the normal steady state between releases). The recommendedclaude plugin updatereinstalled the same version, so the loop never broke.The fix compares the installed cache folder against
plugin.jsononmainviagh api(the actual source the marketplace installs from), not against the latest GitHub release tag. The command now uses a singlegh api --jqinvocation with gh's embedded jq, which also resolves a latent error-handling bug: a multi-stage pipeline's|| echo SENTINELnever fired becausejqon empty input exits 0.New regression tests extract the pre-resolution command from SKILL.md and execute it against a mocked
ghon PATH, emulating gh's embedded jq in-process (no hostjqrequired). They prove the command reads fromplugin.json, not release tags, and that the sentinel fires when upstream is unavailable.Fixes #659.