Skip to content

Conversation

@Mikihero
Copy link
Collaborator

No description provided.

@Mikihero Mikihero marked this pull request as draft August 17, 2024 22:28
@Mikihero Mikihero marked this pull request as ready for review August 17, 2024 22:43
@Mikihero
Copy link
Collaborator Author

@Misfiy review my pr !!

Copy link

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Hope that project is compiling and everything is working as expected

@vladflotsky vladflotsky added the enhancement New feature or request label Sep 3, 2024
@Mikihero Mikihero requested a review from vladflotsky September 3, 2024 16:08
@Mikihero Mikihero requested a review from vladflotsky September 7, 2024 22:33
@vladflotsky
Copy link

Did you test all changes at all?

@Mikihero
Copy link
Collaborator Author

Mikihero commented Sep 8, 2024

everything before your first review was tested, everything after wasn't, if you want I can quickly check if everything is still fine

@vladflotsky
Copy link

Also it will be nice if make all features disabled by default, for example, auto nuke, periodical broadcast message and etc

@Mikihero
Copy link
Collaborator Author

Also it will be nice if make all features disabled by default, for example, auto nuke, periodical broadcast message and etc

sounds good, I will get on it when I can

@Mikihero
Copy link
Collaborator Author

actually, I'll leave some features enabled like the disarmed escapes since disabling it would require me to delete that part from the config and it serves as a guide for people on how to input the values correctly

@vladflotsky vladflotsky merged commit 61ec80a into ExMod-Team:master Sep 28, 2024
Mikihero added a commit that referenced this pull request Jun 17, 2025
* Rework (#1)

* changes

* more changes

* indents I think

* mainly event handler changes

* more handler changes

* updated bug template

* fuck off stylecop

* custom item and custom role support for input and output of 914 custom recipes, name consistency changes

* mostly readme

* better naming

* possible fix

* work on some errors

* asd

* tested spawn inventories, removed unncecessary shit

* readded api methods as yamato suggested, slightly changed project structure

* requested changes

* forgot these two lol

* I did indeed forgot about the second handler

* brainfart moment

* revert breaking config changes

* disabled most configs by default

* v bumpo

* the point of not removing this was to not break shit lol

* updated readme, exiled package, added roledamagereceived multiplier

* remove breaking change

* small config name change

* fixed a possible nre if the config was fucked up

* bump

* update Plugin.props

* fixed 914 player upgrade not working and throwing nre, improved debug logging to be more verbose

* severely improved debug logs and minor tweaks

* bump

* fixed a possible nre

* bump

* changed package

* updated to exiled 9

* fix for some 914 upgrade items getting stuck in the ground

* v bump

* fixed onplayerverified nre

* Exiled 9.6 Update

* removed usings

---------

Co-authored-by: Miki_hero <100715076+Mikihero@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants