Skip to content

Conversation

@xtian
Copy link
Contributor

@xtian xtian commented Oct 13, 2025

  • Move sign_transaction/2 and accounts/1 definition into conditional to fix "previous clause always matches" warning
  • Remove deprecated struct update syntax

Copy link
Member

@alisinabh alisinabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 💜

@alisinabh alisinabh requested a review from Copilot October 13, 2025 14:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Elixir compiler warnings by reorganizing conditional function definitions and updating deprecated struct syntax.

  • Moved fallback function definitions to the else clause of the conditional to prevent "previous clause always matches" warnings
  • Updated deprecated struct update syntax to use the modern format

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/ethers/transaction/signed.ex Updated struct update syntax from deprecated format to modern syntax
lib/ethers/signer/local.ex Reorganized conditional function definitions to use proper if/else structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alisinabh alisinabh merged commit dd20b6e into ExWeb3:main Oct 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants