SOF-6144: JSON Schemas features for InMemoryEntity #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timurbazhirov
approved these changes
Jul 28, 2022
src/JSONSchemasInterface.js
Outdated
|
|
||
| export const JSONSchemasInterface = { | ||
| schemas() { | ||
| return schemas; |
Member
There was a problem hiding this comment.
- This could be a static variable
- Maybe
allSchemasfor clarity - Is this ever used?
src/JSONSchemasInterface.js
Outdated
| import { schemas } from "@exabyte-io/esse.js/schemas"; | ||
| import mergeAllOf from "json-schema-merge-allof"; | ||
|
|
||
| const schemaCache = new Map(); |
Member
There was a problem hiding this comment.
Nitpick, but schemasCache would be more appropriate
src/JSONSchemasInterface.js
Outdated
| return schemas; | ||
| }, | ||
|
|
||
| schemaById(schemaId) { |
Member
There was a problem hiding this comment.
Docstring to define schemaId pls
src/JSONSchemasInterface.js
Outdated
|
|
||
| resolvedSchemaById(schemaId) { | ||
| return this.schemaById(schemaId); | ||
| }, |
src/JSONSchemasInterface.js
Outdated
|
|
||
| const schemaCache = new Map(); | ||
|
|
||
| export const JSONSchemasInterface = { |
Member
There was a problem hiding this comment.
export class JSONSchemasInterface() {
static allSchemas = schemas;
...
}
src/entity/in_memory.js
Outdated
| return null; | ||
| } | ||
|
|
||
| static getMainJsonSchema() { |
Member
There was a problem hiding this comment.
static get baseJSONSchema
tests/JSONSchemasInterface.tests.js
Outdated
|
|
||
| describe("JSONSchemasInterface", () => { | ||
|
|
||
| it("can find schema", () => { |
Member
There was a problem hiding this comment.
Maybe just go through all schemas and all mixes in the 2 tests
package.json
Outdated
| "@babel/preset-react": "7.16.7", | ||
| "@babel/register": "^7.16.0", | ||
| "@babel/runtime-corejs3": "7.16.8", | ||
| "@exabyte-io/esse.js": "github:Exabyte-io/esse#b5516137e018dd35a060fce519dcd058eeff70c9", |
Member
There was a problem hiding this comment.
Let's use npm published version
src/utils/schemas.js
Outdated
| @@ -0,0 +1,85 @@ | |||
| import { JSONSchemasInterface } from "../JSONSchemasInterface"; | |||
|
|
|||
| export const mainSchemas = { | |||
k0stik
pushed a commit
that referenced
this pull request
Jul 31, 2023
SOF-6144: JSON Schemas features for InMemoryEntity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.