chore/SOF-1549: Enable user to specify target k-point density per 1/Angstrom #42
Conversation
| l[k].classNames = v.classNames | ||
| ? `${v.classNames} ${this.defaultClassNames}` | ||
| : this.defaultClassNames; | ||
| return null; |
There was a problem hiding this comment.
Not sure what happened here...
There was a problem hiding this comment.
Previously, it would add undefined to the default class name if the UI schema did not have a classNames property for the given field. I just changed the logic to only add classNames to the string if it is actually defined.
While working on this, I found the behavior of this function a bit counterintuitive, and perhaps we want to consider changing it so that whenever classNames is present in the UI schema, it overwrites rather than prepends the default class names.
There was a problem hiding this comment.
- The above could be done with just:
l[k].classNames = `${v.classNames || ''} ${this.defaultClassNames || ''}`;- It seems that you changes the logic for
...this.defaultFieldStylesalso - is that intentional?
There was a problem hiding this comment.
Regarding 2, defaultFieldStyles already contains classNames and it seemed redundant, but I will change it back so that one may implement a custom version locally (which is not currently the case).
chore/SOF-1549: Enable user to specify target k-point density per 1/Angstrom
No description provided.