Skip to content

Conversation

@Cronan
Copy link
Contributor

@Cronan Cronan commented May 30, 2018

Fixes #9

If your library has x86 or x64 compiled-code and COM dependencies, then an AnyCPU build of ExcelDnaDoc will not work, and throws a 'BadFormatException'.

This change allows x86 and x64 builds.
Samples are not built when choosing x86 or x64

@Cronan
Copy link
Contributor Author

Cronan commented May 31, 2018

@govert @augustoproiete

@govert
Copy link
Member

govert commented May 31, 2018

@augustoproiete So if my library is mixed code and targets x86, then the ExcelDnaDoc that processes it needs to be x86 itself?

@govert govert merged commit a49514e into Excel-DNA:master May 31, 2018
@govert
Copy link
Member

govert commented May 31, 2018

Sorry, I meant @Cronan ...

@Cronan
Copy link
Contributor Author

Cronan commented May 31, 2018 via email

@govert
Copy link
Member

govert commented May 31, 2018

I presume an alternative would be to use something like Mono.Cecil to examine the assemblies.
But that would be a bigger job to tackle, and I'm not sure how typical the mixed assembly case is for Excel-DNA.

@govert
Copy link
Member

govert commented May 31, 2018

I guess this means the NuGet spec would need to have platform-specific binaries.
Should I add an issue to track this?

@Cronan
Copy link
Contributor Author

Cronan commented May 31, 2018 via email

@Cronan
Copy link
Contributor Author

Cronan commented May 31, 2018 via email

@Cronan Cronan deleted the adds_builds branch May 31, 2018 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BadImageFormatException

2 participants