fix(swaps): prevent crash on send payment failure

sangaman · sangaman · commit 555349e1abce · 2019-08-16T17:08:57.000-04:00
This fixes a bug where we would attempt to set a swap as successful after it had errored due to a send payment failure. Fixes #1155.
diff --git a/lib/swaps/Swaps.ts b/lib/swaps/Swaps.ts
@@ -700,6 +700,7 @@ class Swaps extends EventEmitter {
         failureReason: SwapFailureReason.SendPaymentFailure,
         errorMessage: err.message,
       });
+      return;
     }
 
     // swap succeeded!

Original file line number	Diff line number	Diff line change
`@@ -700,6 +700,7 @@ class Swaps extends EventEmitter {`
`700`	`700`	`failureReason: SwapFailureReason.SendPaymentFailure,`
`701`	`701`	`errorMessage: err.message,`
`702`	`702`	`});`
	`703`	`+ return;`
`703`	`704`	`}`
`704`	`705`
`705`	`706`	`// swap succeeded!`