fix(raiden): cleanup reconnectTimer on shutdown

This commit fixes a bug where the Raiden reconnect timer would not
cleanup when triggering a graceful shutdown.

In addition, reconnect timer cleanup has been moved into the
`BaseClient`.

Author: Karl Ranna

lib/BaseClient.ts

@@ -45,6 +45,14 @@ abstract class BaseClient extends EventEmitter {
   public isDisconnected(): boolean {
     return this.status === ClientStatus.Disconnected;
   }
+  /** Ends all connections, subscriptions, and timers for for this client. */
+  public close() {
+    if (this.reconnectionTimer) {
+      clearTimeout(this.reconnectionTimer);
+    }
+    this.closeSpecific();
+  }
+  protected abstract closeSpecific(): void;
 }
 
 export default BaseClient;

lib/Xud.ts

@@ -189,6 +189,9 @@ class Xud extends EventEmitter {
     for (const currency in this.lndClients) {
       this.lndClients[currency]!.close();
     }
+    if (!this.raidenClient.isDisabled()) {
+      this.raidenClient.close();
+    }
     // TODO: ensure we are not in the middle of executing any trades
     const closePromises: Promise<void>[] = [];
 

lib/lndclient/LndClient.ts

@@ -340,15 +340,11 @@ class LndClient extends BaseClient {
       });
   }
 
-  /** Ends all subscriptions and reconnection attempts. */
-  public close = () => {
+  /** Lnd client specific cleanup. */
+  protected closeSpecific = () => {
     if (this.invoiceSubscription) {
       this.invoiceSubscription.cancel();
     }
-
-    if (this.reconnectionTimer) {
-      clearTimeout(this.reconnectionTimer);
-    }
   }
 }
 

lib/raidenclient/RaidenClient.ts

@@ -315,6 +315,9 @@ class RaidenClient extends BaseClient {
     const body = await parseResponseBody<{ our_address: string }>(res);
     return body.our_address;
   }
+
+  /** Raiden client specific cleanup. */
+  protected closeSpecific() {}
 }
 
 export default RaidenClient;