-
Notifications
You must be signed in to change notification settings - Fork 57
Upgrade DependencyInjection to Symfony 2.7 #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This checks if "setFactory" is available in favor of "setFactoryClass".
|
+1 |
1 similar comment
|
+1 |
|
Update dependencies in composer.json |
|
@spolischook You mean enforcing Symfony 2.7 in the deps? My fix doesn't change the minimal required version. |
|
👍 |
|
it's add Symfony 2.7 support? Other parts is work good with 2.7? |
|
Yes, this was the code triggering deprecated notices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this code use separate method with
/**
* @deprecated from symfony 2.7
**/
comment above it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the code should trigger a deprecation notice as there is nothing which is deprecated itself. It will run fine with Symfony <2.7 and >=2.7.
The FriendsOfSymfony solved it the same way:
Yes, I haven't found any other issue yet. Symfony 2.7 deprecates the https://github.com/symfony/symfony/blob/2.7/UPGRADE-3.0.md#dependencyinjection |
|
Could somebody merge it ? ping @cystbear |
|
+1. Could we merge this upstream? ping @spolischook |
|
@althaus does this stuff works? |
|
@cystbear Yes, our fork runs fine with 2.7 in our dev environment. The fix isn't big magic. |
|
👍 Works for me, it is just replacing the old methods by the new ones ;) |
Upgrade DependencyInjection to Symfony 2.7
|
Thanks for contributing! |
|
@spolischook Thanks for the merge. Could you tag a new release for Composer? |
This checks if "setFactory" is available in favor of "setFactoryClass".