fix(initiate-deployment): add auto_merge parameter#106
Merged
danadajian merged 6 commits intoExpediaGroup:mainfrom Jan 31, 2022
Merged
Conversation
Contributor
|
@pongraczl Thanks for finding this! Instead of adding an additional input, could we instead always set |
Contributor
Author
|
@danadajian Thanks! Then I simplified those changes to fixed value with |
danadajian
approved these changes
Jan 31, 2022
|
🎉 This PR is included in version 1.14.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Set
auto_mergeparameter ininitiate-deploymenthelper always tofalse.auto_merge: true)The default value is true (this is what initiate-deployment is currently using).Adding this parameter gives more control over the behavior of this helper.🔗 Related Issues
When a PR is not up-to-date with master,
auto_merge=truemakes the helper failing, but being up-to-date with master is not a requirement in all cases.