-
Notifications
You must be signed in to change notification settings - Fork 21
Patch 602 #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 602 #112
Conversation
tlivings
commented
Jul 18, 2025
- Updated documentation, in particular data sources
- Added cursor rules for improved LLM experience
- Added more tests
- Performed performance optimizations in proxy and context building
…rces, removed dist folder from checking in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's with the removal of these build files (and addition of them to .gitignore and .npmignore)?
package.json is still referencing them. are they going to be created by other means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are published, just not checked in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They shouldn't be .npmignored though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are the dist files getting generated? i don't see a reference to the build script in the github workflows (although some steps are named "build", they just run the tests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm publish action -> prepublish -> build, which does tsc.
|
|
||
| this._context = async (globalContext: Record<string, unknown>): Promise<TContextType> => { | ||
| //TODO: currently the context injected into data sources won't have data sources on it | ||
| //BREAKING: The context injected into data sources won't have data sources on it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this code comment is a bit confusing. is the "BREAKING" part needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it's a correction of what was a breaking change from a TODO to fix, to disregarding but leaving a comment for context.