Skip to content

Conversation

@tlivings
Copy link
Collaborator

  • Updated documentation, in particular data sources
  • Added cursor rules for improved LLM experience
  • Added more tests
  • Performed performance optimizations in proxy and context building

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's with the removal of these build files (and addition of them to .gitignore and .npmignore)?

package.json is still referencing them. are they going to be created by other means?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are published, just not checked in.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They shouldn't be .npmignored though

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how are the dist files getting generated? i don't see a reference to the build script in the github workflows (although some steps are named "build", they just run the tests)

Copy link
Collaborator Author

@tlivings tlivings Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm publish action -> prepublish -> build, which does tsc.


this._context = async (globalContext: Record<string, unknown>): Promise<TContextType> => {
//TODO: currently the context injected into data sources won't have data sources on it
//BREAKING: The context injected into data sources won't have data sources on it
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code comment is a bit confusing. is the "BREAKING" part needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's a correction of what was a breaking change from a TODO to fix, to disregarding but leaving a comment for context.

@tlivings tlivings merged commit b6b88f3 into ExpediaGroup:master Sep 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants