fix: generate Kotlin interfaces rather than open classes #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danadajian
force-pushed
the
switch-to-interface
branch
from
34e68c2 to
4ebea8f
Compare
danadajian
changed the title
MicahWitthaus
approved these changes
May 8, 2024
| packageName: optional(string()), | ||
| /** | ||
| * Denotes types that should be generated as classes. Resolver classes can inherit from these to enforce a type contract. | ||
| * Denotes types that should be generated as interfaces rather than classes. Resolver classes should inherit from these to enforce a type contract. |
There was a problem hiding this comment.
Nit: "Resolver classes should implement the interface functions to enforce a type contract".
|
🎉 This PR is included in version 3.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
danadajian
added a commit
that referenced
this pull request
May 8, 2024
danadajian
added a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The change in v3.0.0 to generate open classes was a mistake. These should be Kotlin interfaces or abstract classes, not open classes. This will ensure more strict inheritance which is more appropriate for the use cases here.
resolverClassesconfig toresolverInterfacesinterfacerather thanopen classforresolverInterfacestypes and types whose fields all have argumentsabstract classrather thanopen classfor types where some but not all fields have argumentsThis is technically a breaking change, but will release this as a bug fix because it corrects this massive oversight.