Skip to content

Conversation

@smyrick
Copy link
Contributor

@smyrick smyrick commented Feb 27, 2019

It looks like the conditional for deployment.on.jdk is a single version not an array. This would make sense if we don't want both jobs to publish a jar

https://docs.travis-ci.com/user/deployment#conditional-releases-with-on

@smyrick smyrick added changes: no version type: tool update CI, code coverage, or linter updates and removed changes: no version labels Feb 27, 2019
@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #178 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
- Coverage     98.52%   98.34%   -0.19%     
  Complexity      162      162              
============================================
  Files            55       55              
  Lines           543      543              
  Branches         94       94              
============================================
- Hits            535      534       -1     
  Misses            4        4              
- Partials          4        5       +1
Impacted Files Coverage Δ Complexity Δ
...pedia/graphql/generator/types/ObjectTypeBuilder.kt 95% <0%> (-5%) 3% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba50860...be0fda8. Read the comment docs.

@dariuszkuc dariuszkuc merged commit a9eeba7 into ExpediaGroup:master Feb 27, 2019
@smyrick smyrick deleted the travis-deploy branch February 27, 2019 16:37
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: tool update CI, code coverage, or linter updates

Development

Successfully merging this pull request may close these issues.

2 participants