Skip to content

Conversation

@smyrick
Copy link
Contributor

@smyrick smyrick commented Oct 22, 2019

📝 Description

Migrate the actions Maven check to java 11

Also per this issue, we should be running ScanResult::close if we no longer need to use the reflection results: classgraph/classgraph#331

@smyrick smyrick added the type: tool update CI, code coverage, or linter updates label Oct 22, 2019
@smyrick smyrick force-pushed the gh-actions-java-11 branch from 40ae735 to 034b2ce Compare October 22, 2019 21:43
@smyrick smyrick force-pushed the gh-actions-java-11 branch from 034b2ce to 08c05f9 Compare October 22, 2019 21:43
@smyrick smyrick changed the title Gh actions java 11 Update GH actions to use java 11 Oct 22, 2019
@codecov-io
Copy link

codecov-io commented Oct 22, 2019

Codecov Report

Merging #451 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #451      +/-   ##
============================================
+ Coverage     97.94%   97.95%   +<.01%     
- Complexity      328      330       +2     
============================================
  Files           106      106              
  Lines          1265     1270       +5     
  Branches        207      207              
============================================
+ Hits           1239     1244       +5     
  Misses            7        7              
  Partials         19       19
Impacted Files Coverage Δ Complexity Δ
...expediagroup/graphql/generator/state/TypesCache.kt 100% <100%> (ø) 21 <1> (+1) ⬆️
...om/expediagroup/graphql/generator/SubTypeMapper.kt 100% <100%> (ø) 6 <1> (+1) ⬆️
.../expediagroup/graphql/generator/SchemaGenerator.kt 100% <100%> (ø) 21 <0> (ø) ⬇️
...oup/graphql/federation/FederatedSchemaGenerator.kt 100% <100%> (ø) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4abb38f...595a3fd. Read the comment docs.

@smyrick smyrick added the changes: patch Changes require a patch version label Oct 25, 2019
@smyrick smyrick changed the title Update GH actions to use java 11 Fix GH actions PR check Oct 25, 2019
@tapaderster tapaderster merged commit 0a995c3 into ExpediaGroup:master Oct 25, 2019
@smyrick smyrick deleted the gh-actions-java-11 branch October 25, 2019 19:31
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
* Migrate GH actions to java 11

* Update maven.yml

* Update maven.yml

* Trying to fix classloader for SubTypeMapper

* Close scan result on generator complete

* Close results in federation scanning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes: patch Changes require a patch version type: tool update CI, code coverage, or linter updates

Development

Successfully merging this pull request may close these issues.

3 participants