Skip to content

Commit 6b6f06a

Browse files
Move VerticalCreditCards MenuItem inline with other section items
Remove the special background color and custom icon sizing from the company cards MenuItem. Wrap it in a View with the same negative margin and padding styles as the other MenuItems in the section. Remove centralPaneContainerStyle that zeroed out bottom padding when no cards were assigned. Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
1 parent 463f94e commit 6b6f06a

1 file changed

Lines changed: 14 additions & 16 deletions

File tree

  • src/pages/settings/Wallet/WalletPage

src/pages/settings/Wallet/WalletPage/index.tsx

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -680,7 +680,6 @@ function WalletPage() {
680680
title={translate('walletPage.assignedCards')}
681681
isCentralPane
682682
subtitleMuted
683-
centralPaneContainerStyle={!hasAssignedCard ? styles.pb0 : undefined}
684683
titleStyles={styles.accountSettingsSectionTitle}
685684
>
686685
<>
@@ -716,21 +715,20 @@ function WalletPage() {
716715
/>
717716
</View>
718717
)}
719-
{!hasAssignedCard ? (
720-
<MenuItem
721-
iconHeight={48}
722-
iconWidth={48}
723-
containerStyle={styles.hoveredComponentBG}
724-
shouldShowRightIcon
725-
icon={illustrations.VerticalCreditCards}
726-
displayInDefaultIconColor
727-
wrapperStyle={styles.sectionMenuItemTopDescription}
728-
title={translate('personalCard.lookingForCompanyCards')}
729-
description={translate('personalCard.lookingForCompanyCardsDescription')}
730-
titleStyle={styles.textStrong}
731-
onPress={openCompanyCardFlow}
732-
/>
733-
) : null}
718+
{!hasAssignedCard && (
719+
<View style={[styles.mt5, shouldUseNarrowLayout ? styles.mhn5 : styles.mhn8]}>
720+
<MenuItem
721+
shouldShowRightIcon
722+
icon={illustrations.VerticalCreditCards}
723+
displayInDefaultIconColor
724+
wrapperStyle={[styles.paymentMethod, shouldUseNarrowLayout ? styles.ph5 : styles.ph8]}
725+
title={translate('personalCard.lookingForCompanyCards')}
726+
description={translate('personalCard.lookingForCompanyCardsDescription')}
727+
titleStyle={styles.textStrong}
728+
onPress={openCompanyCardFlow}
729+
/>
730+
</View>
731+
)}
734732
</Section>
735733
)}
736734

0 commit comments

Comments
 (0)