This repository was archived by the owner on Mar 21, 2022. It is now read-only.
User Batch Creation #170
Merged
User Batch Creation #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To create multiple users, it is no longer necesarry to create a record for every single user + their corresponding user preferences. We only need one userbatchrequest record and save it. Additionally, the function saveUser and saveMultipleUsers were refactored to be ember-concurrency tasks, which saves the need of the showSpinner property.
When creating a new user, enabling default settings button will not create any user preferences. When editing a user, using default settings results in the user preferences being deleted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request belongs to ExplorViz-Archive/explorviz-backend#77.
Instead of creating all user records and userpreference records in the frontend, we now only create a single userbatchrequest record and save it, which results in a single request to the user-service.
The mocks were also changed accordingly.
Furthermore, a 'use default settings' option was added, which allows the user to enable default settings or the admin user to create users with default settings (no user preferences).