-
Notifications
You must be signed in to change notification settings - Fork 78
Modernizing existing addons #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| The ExpressionEngine 7.2 release brough a new add-on developemnt approach, which generates the majority of the add-ons needed files and struture. It also bring additional organization to how add-ons are developed. | ||
|
|
||
| NOTE: These changes do NOT break existing add-ons. The old development methodologies will still work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomJaeger I would look to move this down in the narrative. More explanation up top. OR, take out the Note: portion.
|
|
||
| NOTE: These changes do NOT break existing add-ons. The old development methodologies will still work. | ||
|
|
||
| The idea of a plugin, module, extension, fieldtype, etc. no longer exist. Instead an add-on can have a template tag, or a field-type, or an extention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomJaeger It appears as though the idea still exists, but has changed. May be better language around that.
Extension is misspelled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dougblackjr can you review what I changed it to? Does that sum it up well, or do you think it would be better worded in a different way?
|
|
||
| In order to harness the new add-on development methodology, you will have to do a few SMALL updates to your existing add-on's. | ||
|
|
||
| TIP: You don't have to migrate your add-on to the new development methodology. After making the following changes, you can leave your add-ons as is, and start new / additional development in the new method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this into the paragraph above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dougblackjr I merged these two sentences and reworded them a bit. What do you think of the rewording?
| class Addon_upd extends Installer | ||
| ``` | ||
| ## A Note on Plugins | ||
| If your add-on is currently a plugin and your looking to take advantage of the new add-on development methodologies, we recommend migrating your plugin methods (functions) to your mod file first. This can be done with a simple copy and paste. No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be worthwhile to add a section about moving methods to the different files as well. For example, in my legacy extension, how do I move that an Extensions file?
…ted example of auto upgrades to add-ons
robinsowell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made sense to me, though I am still a bit unclear on what I would gain modernizing an old, existing add-on. If it's working fine and you're not making any changes/additions to it, then leaving it alone is fine. It's only if it's in development, you'd probably want to modernize before moving forward on adding things- at least that would be my read.
Added section on Modernizing Existing Add-ons, and linked to it from a few places in add-on development section.