Skip to content

Fix thinking detection logic in Hermes 2 Pro function for diverse template patterns #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix thinking detection logic in Hermes 2 Pro function for diverse template patterns #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
486155f
Initial plan
Copilot Aug 25, 2025
b3c4883
Fix thinking detection logic for Hermes 2 Pro function to handle dive…
Copilot Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions common/chat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1767,9 +1767,14 @@ static common_chat_params common_chat_params_init_hermes_2_pro(const common_chat
}

if (!inputs.tools.is_null()) {
auto supports_thinking = tmpl.source().find("<think>") != std::string::npos;
// you should not be able to call enable_thinking if <think> is not supported
GGML_ASSERT(!extra_context["enable_thinking"] || extra_context["enable_thinking"] == supports_thinking);
auto supports_thinking = tmpl.source().find("<think>") != std::string::npos ||
tmpl.source().find("'<think>\\n'") != std::string::npos ||
tmpl.source().find("\"<think>\\n\"") != std::string::npos;

// If the template doesn't support thinking, disable thinking regardless of the input setting
if (!supports_thinking && extra_context["enable_thinking"]) {
extra_context["enable_thinking"] = false;
}
// (content)?(<tool_call>{"name": "foo", "arguments": {"a": 1}}</tool_call>)*
data.grammar_lazy = true;
data.grammar = build_grammar([&](const common_grammar_builder & builder) {
Expand Down