HostedZoneId and domain are optional for WebServer #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikovac
suggested changes
Nov 24, 2023
src/components/web-server.ts
Outdated
| const hasCustomDomain = domain && hostedZoneId; | ||
| if (domain && !hostedZoneId) { | ||
| throw new Error( | ||
| 'NuxtSSR:hostedZoneId must be provided when the domain is specified', |
Contributor
There was a problem hiding this comment.
You should change NuxtSSR to WebServer
src/components/web-server.ts
Outdated
Comment on lines
264
to
266
| const ecsDependencies = [this.lb, this.lbTargetGroup, this.lbHttpListener]; | ||
| if (this.lbTlsListener) ecsDependencies.push(this.lbTlsListener); | ||
|
|
Contributor
There was a problem hiding this comment.
I think we can only keep lb and lbTargetGroup as dependencies here.
ikovac
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes hostedZoneId and domain optional for web server
Link to issue: #11