Mongo service random password #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikovac
suggested changes
Nov 24, 2023
| serviceName: string; | ||
| username: pulumi.Input<string>; | ||
| password: pulumi.Input<string>; | ||
| password?: pulumi.Input<string>; |
Contributor
There was a problem hiding this comment.
Please also describe in the readme that if the password is not provided it will be auto-generated.
src/components/mongo.ts
Outdated
| */ | ||
| username: pulumi.Input<string>; | ||
| /** | ||
| * Password for the master DB user. |
Contributor
There was a problem hiding this comment.
Update comment to describe password autogeneration (same as with rds password).
src/components/mongo.ts
Outdated
| } | ||
|
|
||
| private createRandomPassword() { | ||
| return new random.RandomPassword(`${this.name}-db-password`, { |
Contributor
There was a problem hiding this comment.
Suggested change
| return new random.RandomPassword(`${this.name}-db-password`, { | |
| return new random.RandomPassword(`${this.name}-mongo-password`, { |
src/components/mongo.ts
Outdated
Comment on lines
82
to
86
| return new random.RandomPassword(`${this.name}-db-password`, { | ||
| length: 16, | ||
| overrideSpecial: '_%$', | ||
| special: true, | ||
| }).result; |
Contributor
There was a problem hiding this comment.
Suggested change
| return new random.RandomPassword(`${this.name}-db-password`, { | |
| length: 16, | |
| overrideSpecial: '_%$', | |
| special: true, | |
| }).result; | |
| const password = new random.RandomPassword(`${this.name}-db-password`, { | |
| length: 16, | |
| overrideSpecial: '_%$', | |
| special: true, | |
| }); | |
| return password.result; |
Feel free to ignore this readability improvement if you don't like it.
ikovac
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds random password to mongo service if no password is provided