Skip to content

Add numberOfAvailabilityZones param to Project constructor #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Add numberOfAvailabilityZones param to Project constructor #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2e5169
Add numberOfAvailabilityZones param to Project constructor
mbareta Feb 15, 2024
e9f5c61
Use already defined type
ikovac Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,15 @@ type ProjectArgs = {
| EcsServiceOptions
)[];
enableSSMConnect?: pulumi.Input<boolean>;
numberOfAvailabilityZones?: number;
};
```

| Argument | Description |
| :--------------- | :----------------------------------------------------------------------------------------------------------------------------------------------------------: |
| services \* | Service list. |
| enableSSMConnect | Setup ec2 instance and SSM in order to connect to the database in the private subnet. Please refer to the [SSM Connect](#ssm-connect) section for more info. |
| numberOfAvailabilityZones | Default is 2 which is recommended. If building a dev server, we can reduce to 1 availability zone to reduce hosting cost. |
Copy link
Contributor

@ikovac ikovac Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also thinking about updating documentation ❤️


```ts
type DatabaseServiceOptions = {
Expand Down
9 changes: 6 additions & 3 deletions src/components/project.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ export type ProjectArgs = {
| EcsServiceOptions
)[];
enableSSMConnect?: pulumi.Input<boolean>;
numberOfAvailabilityZones?: number;
};

export class MissingEcsCluster extends Error {
Expand All @@ -141,7 +142,7 @@ export class Project extends pulumi.ComponentResource {
super('studion:Project', name, {}, opts);
this.name = name;

this.vpc = this.createVpc();
this.vpc = this.createVpc(args.numberOfAvailabilityZones);
this.createServices(args.services);

if (args.enableSSMConnect) {
Expand All @@ -155,11 +156,13 @@ export class Project extends pulumi.ComponentResource {
this.registerOutputs();
}

private createVpc() {
private createVpc(
numberOfAvailabilityZones: ProjectArgs['numberOfAvailabilityZones'] = 2,
) {
const vpc = new awsx.ec2.Vpc(
`${this.name}-vpc`,
{
numberOfAvailabilityZones: 2,
numberOfAvailabilityZones,
enableDnsHostnames: true,
enableDnsSupport: true,
subnetSpecs: [
Expand Down