Add DatabaseReplica component #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbareta
commented
Mar 5, 2024
| }>; | ||
| }; | ||
|
|
||
| const defaults = { |
Collaborator
Author
There was a problem hiding this comment.
@ikovac should I put defaults from this and the Database component to constants file and reuse or do we want to have them separate? I just noticed we have skipFinalSnapshot here which does not apply to replica.
Also, based on our offline talk, replicas can have multiAz too.
Contributor
There was a problem hiding this comment.
I think we can keep them separate
mbareta
changed the title
ikovac
approved these changes
Mar 11, 2024
Contributor
ikovac
left a comment
ikovac
left a comment
There was a problem hiding this comment.
Please just fix docs and we can merge it. Thanks! 🙌
README.md
Outdated
| The database password is stored as a secret inside AWS Secret Manager. | ||
| The secret will be available on the `Database` resource as `password.secret`. | ||
|
|
||
| ### Database |
README.md
Outdated
Comment on lines
386
to
392
| AWS RDS Postgres instance. | ||
|
|
||
| Features: | ||
|
|
||
| - enabled encryption with a symmetric encryption key | ||
| - deployed inside an isolated subnet | ||
| - backup enabled with retention period set to 14 days |
Contributor
There was a problem hiding this comment.
Do we also need to update the description?
| }>; | ||
| }; | ||
|
|
||
| const defaults = { |
Contributor
There was a problem hiding this comment.
I think we can keep them separate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.