Add mongo service #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
November 2, 2023 10:16
ikovac
suggested changes
Nov 7, 2023
ikovac
suggested changes
Nov 7, 2023
Contributor
|
@ptrutanicex Please also update the documentation with Mongo service in the scope of this PR |
added 13 commits
November 8, 2023 13:23
added 10 commits
November 14, 2023 16:12
ikovac
suggested changes
Nov 15, 2023
ikovac
suggested changes
Nov 16, 2023
src/components/mongo.ts
Outdated
| const port = args.port || 27017; | ||
|
|
||
| this.name = name; | ||
| this.service = new Ecs( |
Contributor
There was a problem hiding this comment.
Maybe it also makes sense to set public property host to be equal to the service discovery hostname.
Also I think it makes sense to store mongo password to the secret manager like we did with redis and rds
Contributor
There was a problem hiding this comment.
Please also update docs with mongo secret so that consumers know that the secret is created
ikovac
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds mongo service to infra code blocks.
Closes #2