feat: enable deploying multiple containers to a single ECS service #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiroDojkic
force-pushed
the
feature/multi-container-ecs
branch
4 times, most recently
from
4e0f2d2 to
5c09b05
Compare
droguljic
requested changes
Apr 7, 2025
| const logGroup = new aws.cloudwatch.LogGroup( | ||
| `${this.name}-log-group`, | ||
| { | ||
| retentionInDays: 14, |
Contributor
There was a problem hiding this comment.
Why is this hardcoded? Shouldn't this be indefinite (which is set by default) for the production env?
Member
Author
There was a problem hiding this comment.
Good question. This was inherited from the original service.
I don't think we should have it infinite though, as it impact storage cost and the risk of retaining sensitive information too long.
I suggest we make this configurable with options for staging and prod environments, as we did with sizes, in a separate PR - for example 3, 14, and 90 days.
MiroDojkic
force-pushed
the
feature/multi-container-ecs
branch
from
f2eacef to
1c033c3
Compare
droguljic
approved these changes
Apr 7, 2025
This was referenced Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
volumeseparately from container's mount points - instead of providingpersistentStorageConfig