Skip to content

Conversation

@droguljic
Copy link
Contributor

Use references to organize TS configuration with following improvements:

  • clear separation between different parts of the project
  • no need for nested package.json files
  • run tests without installing dependencies and building project first

@droguljic droguljic requested a review from MiroDojkic April 28, 2025 15:29
@MiroDojkic
Copy link
Member

MiroDojkic commented Apr 28, 2025

@droguljic am I getting this right - with this approach, if anything breaks in the build process our tests won't catch it?

Use references to organize TS configuration with following improvements:
- clear separation between different parts of the project
- no need for nested `package.json` files
- run tests without installing dependencies and building project first
@droguljic droguljic force-pushed the chore/ts-references branch from 028e284 to 833d94d Compare April 29, 2025 10:50
@droguljic
Copy link
Contributor Author

@droguljic am I getting this right - with this approach, if anything breaks in the build process our tests won't catch it?

That is a great observation.
Previous approach had a side effect of checking the build process due to set up with alias, nested package.json and double install command. Also, it would check the build process once changes were merged into trunk, so PR could break build and nothing would be reported.

The intention is to add check build step to the list of jobs that are run on each PR once this is merged.

@MiroDojkic
Copy link
Member

@droguljic thanks for explaining. Can you elaborate on the check build step - how would it check the build?

@MiroDojkic MiroDojkic merged commit 7646a20 into master Apr 29, 2025
1 check passed
@MiroDojkic MiroDojkic deleted the chore/ts-references branch April 29, 2025 12:15
@droguljic
Copy link
Contributor Author

@droguljic thanks for explaining. Can you elaborate on the check build step - how would it check the build?

Just run the build to see if it passes. We can also provide an option to persist build artifacts to the workspace for later use if needed down the line.

@droguljic droguljic mentioned this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants