This repository was archived by the owner on Mar 12, 2021. It is now read-only.
[NDPD-1222] Submissions should allow score points to have a decimal value #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotky
approved these changes
May 10, 2018
vkaracic
reviewed
May 10, 2018
| decimal_places=2, | ||
| default=Decimal('0.0'), | ||
| max_digits=6, | ||
| validators=[MinValueValidator(Decimal('0.0'))] |
There was a problem hiding this comment.
Do users see an error message when one of these fails, or a 500 error?
Collaborator
Author
There was a problem hiding this comment.
I guess consumers handle those errors, SGA does on the front end.
There was a problem hiding this comment.
Oh, didn't realize this doesn't have views/controllers.
vkaracic
approved these changes
May 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's fix NDPD-1222. In case problem weight is set to a decimal value, SGA breaks during scoring process.
This allows score points (earned and max) to have decimal values.
Please review.