Fix start-scheduler and build-scheduler #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was failing because of the usage of import.meta Replace ts-node with tsx and keep using ES modules Still need to fix ncc build
ncc builds CJS format, and won't work with the Config class wich uses import.meta.env, a feature from ES modules
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
This allows to use the same approach everywhere despite web / node script
MiquelAdell
approved these changes
Oct 22, 2025
tokland
approved these changes
Oct 22, 2025
| "process.env.VITE_PRESENTATION_VARIANT": JSON.stringify(env.VITE_PRESENTATION_VARIANT), | ||
| "process.env.VITE_PRESENTATION_TITLE": JSON.stringify(env.VITE_PRESENTATION_TITLE), | ||
| "process.env.VITE_PRESENTATION_TYPE": JSON.stringify(env.VITE_PRESENTATION_TYPE), | ||
| "process.env.VITE_CYPRESS": JSON.stringify(env.VITE_CYPRESS), |
There was a problem hiding this comment.
This also caused issues for us in CPR. Just as a note, what we did there was use vite-node to run the scripts so that the import.meta references keep working.
That’s not to say this approach is wrong, moving everything to environment variables is reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
start-schedulerandbuild-schedulerstopped working as part of the changes in #1014Problem: the project started using ES modules features like
import.meta.env, while the scheduler script was using CJS.start-scheduler: replacedts-nodewithtsx. With this change we can run the scheduler without no further changes, its faster and preferred in latest skeleton versions.build-scheduler:"type": "module"topackage.jsonto have ncc generate a ES modules build, but couldn't get it working in a reasonable time.Configuseprocess.envinstead ofimport.meta.env. Changedvite.config.jsto map theprocess.envvalues for the web build as well. This allows to use the sameConfigclass for both vite web builds and ncc builds.📹 Screenshots/Screen capture
🔥 Is there anything the reviewer should know to test it?