Feature/poetry fix #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
December 13, 2021 15:49
RyanJField
approved these changes
Dec 15, 2021
Collaborator
RyanJField
left a comment
RyanJField
left a comment
There was a problem hiding this comment.
Approved. Code works as should locally and on CI Documentation updated and SEIRS Model runs as expected.
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added poetry
removed setuptools config files
changes to folder to be similar to FAIR cli repo
simpleModel folder on the same level of package
fair cli is now a dependancy
poetry build tested on ubuntu 20.04
updated doc to reflect new folder structure
updated authors list
moved pytest,flake8,black and isort inside pyproject.toml
added mypy precommit hook
fixed mypy issues
fixed typehints