Skip to content

Conversation

@bruvio
Copy link
Collaborator

@bruvio bruvio commented Jan 24, 2022

Implemented a wrapper function to get_first_entry.
exception are still managed in the main code (pipeline.py)

refactored code in few spots.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #36 (ac63f30) into dev (f919b2c) will increase coverage by 0.26%.
The diff coverage is 89.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #36      +/-   ##
==========================================
+ Coverage   86.71%   86.98%   +0.26%     
==========================================
  Files           5        5              
  Lines         512      507       -5     
==========================================
- Hits          444      441       -3     
+ Misses         68       66       -2     
Impacted Files Coverage Δ
fairdatapipeline/pipeline.py 91.66% <85.71%> (-0.36%) ⬇️
fairdatapipeline/raise_issue.py 81.94% <88.88%> (+1.45%) ⬆️
fairdatapipeline/fdp_utils.py 84.40% <100.00%> (+0.16%) ⬆️
fairdatapipeline/link.py 86.84% <100.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f919b2c...ac63f30. Read the comment docs.

@bruvio bruvio requested a review from RyanJField January 24, 2022 12:12
@bruvio bruvio merged commit dacca1b into dev Jan 28, 2022
@bruvio bruvio deleted the feature/more-refactoring branch January 28, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants