Skip to content

Conversation

@girum-air
Copy link
Contributor

No description provided.

@girum-air girum-air requested a review from rhunwicks September 19, 2025 08:38
@girum-air girum-air self-assigned this Sep 19, 2025
@girum-air
Copy link
Contributor Author

There was a “ “ a space instead of ““ in cell BN218 of CD16_14Nov24 file and that trips up the float conversion code for that row for max value.

@rhunwicks rhunwicks removed their request for review September 19, 2025 12:11
@rhunwicks rhunwicks self-assigned this Sep 19, 2025
@rhunwicks
Copy link
Contributor

@girum-air I realised that there were some other inconsistencies in this code, in that we were only converting the value to a percentage when the wealth characteristic is percentage_of_households, but we were converting min/max for any numbers less than 1. Therefore I pushed another commit because it seems easier than explaining. I also raised a better error message if the conversion fails.

Please can you review.

@girum-air
Copy link
Contributor Author

@rhunwicks I approved! Can't do it in the UI cause it was my PR originally

@rhunwicks rhunwicks self-requested a review September 19, 2025 12:33
@rhunwicks rhunwicks merged commit aa8e502 into main Sep 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants