Conversation
This was referenced Apr 12, 2019
Acts as a quick filter (with potential false positives) for candidate members.
fsjovatsen
reviewed
Sep 25, 2019
Contributor
fsjovatsen
left a comment
fsjovatsen
left a comment
There was a problem hiding this comment.
@asgeirn fikser du konfliktene så merger vi etterpå?
# Conflicts: # build.gradle # src/test/groovy/no/fint/cache/FintCacheIntegrationSpec.groovy # src/test/groovy/no/fint/cache/HazelcastCacheIntegrationSpec.groovy
Contributor
Author
@fsjovatsen Fikset nå! |
fsjovatsen
approved these changes
Nov 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables an index for cache members based on hashcodes of their identifiers.
The hashcodes must be provided externally, hence
CacheServiceadds anupdateCache()method where implementing caches can provide the cache members already wrapped inCacheObjectwith the index hashcodes calculated.Cachegets a newfilter(hashcode, Predicate)method to do a first-pass of retrieving all members with matching hashcodes before evaluating the Predicate.The change is backwards compatible, as the methods maintaining and using the index is added alongside the original
CacheService.update()andCache.filter()methods.In order to actually use the index, the consumer must be updated to use these new methods in the model cache services. Code for this is in FINTLabs/fint-consumer#10
Initial tests of this index suggests up to 10x quicker responses on model cache service
getXXbyID()method calls.