Define interfaces of the network module and channel module. #4

MaggieNgWu · 2020-07-10T12:49:06Z

Interfaces include

Channel
MsgHandler
Network

ghost · 2020-07-10T12:50:04Z

Warnings are found on analyzing the commit c4640bd.

5 warnings:

⚠️ Cppcheck
⚠️ Goodcheck
⚠️ Phinder
⚠️ SCSS-Lint
⚠️ There are too many issues on the commit c4640bd for Sider to post all issues. Please review them on the analysis result.

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

ghost · 2020-07-10T12:50:05Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+
+import org.fisco.bcos.sdk.model.Message;
+import org.fisco.bcos.sdk.model.MsgType;
+import java.util.Collection;


[PMD Java] Avoid unused imports such as 'java.util.Collection' (view)

Rule Ruleset Priority

UnusedImports Best Practices 4

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#unusedimports

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-10T12:50:05Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+import org.fisco.bcos.sdk.model.MsgType;
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;


[PMD Java] Avoid unused imports such as 'java.util.Map' (view)

Rule Ruleset Priority

UnusedImports Best Practices 4

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#unusedimports

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-10T12:50:05Z

src/main/java/org/fisco/bcos/sdk/channel/ResponseCallback.java

+ * ResponseCallback is to define a callback to handle response from node
+ */
+public abstract class ResponseCallback {
+    private Message message;


[PMD Java] Avoid unused private fields such as 'message'. (view)

Rule Ruleset Priority

UnusedPrivateField Best Practices 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_bestpractices.html#unusedprivatefield

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-10T12:50:05Z

src/main/java/org/fisco/bcos/sdk/model/Message.java

+ * Messages between sdk and FISCO BCOS node.
+ *
+ */
+public class Message implements Serializable{


[PMD Java] Classes implementing Serializable should set a serialVersionUID (view)

Rule Ruleset Priority

MissingSerialVersionUID Error Prone 3

References:

https://pmd.github.io/pmd-6.24.0/pmd_rules_java_errorprone.html#missingserialversionuid

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-10T12:50:06Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+
+import org.fisco.bcos.sdk.model.Message;
+import org.fisco.bcos.sdk.model.MsgType;
+import java.util.Collection;


[Checkstyle] Wrong lexicographical order for 'java.util.Collection' import. Should be before 'org.fisco.bcos.sdk.model.MsgType'. (view)

Rule Severity

CustomImportOrderCheck warning

References:

https://checkstyle.org/config_imports.html#CustomImportOrder

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-10T12:50:09Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+     * @param groupId
+     * @param callback
+     */
+    void sendToGroup(Message out, String groupId, ResponseCallback callback);


[Checkstyle] 'method def modifier' has incorrect indentation level 4, expected level should be 2. (view)

Rule Severity

IndentationCheck warning

References:

https://checkstyle.org/config_misc.html#Indentation

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-10T12:50:10Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+     */
+    void sendToGroup(Message out, String groupId, ResponseCallback callback);
+
+    /**


[Checkstyle] First sentence of Javadoc is missing an ending period. (view)

Rule Severity

SummaryJavadocCheck warning

References:

https://checkstyle.org/config_javadoc.html#SummaryJavadoc

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-10T12:50:10Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+    /**
+     * Broadcast to all peer
+     *
+     * @param out


[Checkstyle] At-clause should have a non-empty description. (view)

Rule Severity

NonEmptyAtclauseDescriptionCheck warning

References:

https://checkstyle.org/config_javadoc.html#NonEmptyAtclauseDescription

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-10T12:50:10Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+     * Broadcast to all peer
+     *
+     * @param out
+     * @param callback


[Checkstyle] At-clause should have a non-empty description. (view)

Rule Severity

NonEmptyAtclauseDescriptionCheck warning

References:

https://checkstyle.org/config_javadoc.html#NonEmptyAtclauseDescription

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-10T12:50:10Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+     * @param out
+     * @param callback
+     */
+    void broadcast(Message out, ResponseCallback callback);


[Checkstyle] 'method def modifier' has incorrect indentation level 4, expected level should be 2. (view)

Rule Severity

IndentationCheck warning

References:

https://checkstyle.org/config_misc.html#Indentation

You can close this issue if no need to fix it. Learn more.

sonarqubecloud · 2020-07-13T02:04:14Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

ghost · 2020-07-13T02:04:46Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+import org.fisco.bcos.sdk.model.MsgType;
+
+public interface Channel {
+    /**


[Checkstyle] First sentence of Javadoc is missing an ending period. (view)

Rule Severity

SummaryJavadocCheck warning

References:

https://checkstyle.org/config_javadoc.html#SummaryJavadoc

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-13T02:04:46Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+     * @param filepath config file path.
+     * @return
+     */
+    Channel build(String filepath);


[Checkstyle] 'method def modifier' has incorrect indentation level 4, expected level should be 2. (view)

Rule Severity

IndentationCheck warning

References:

https://checkstyle.org/config_misc.html#Indentation

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-13T02:04:46Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+     * Add a message handler to handle specific type messages. When one message comes the handler
+     * will be notified, handler.onMessage(ChannleHandlerContext ctx, Message msg) called.
+     *
+     * @param type


[Checkstyle] At-clause should have a non-empty description. (view)

Rule Severity

NonEmptyAtclauseDescriptionCheck warning

References:

https://checkstyle.org/config_javadoc.html#NonEmptyAtclauseDescription

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-13T02:04:46Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+     * will be notified, handler.onMessage(ChannleHandlerContext ctx, Message msg) called.
+     *
+     * @param type
+     * @param handler


[Checkstyle] At-clause should have a non-empty description. (view)

Rule Severity

NonEmptyAtclauseDescriptionCheck warning

References:

https://checkstyle.org/config_javadoc.html#NonEmptyAtclauseDescription

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-13T02:04:46Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+     * @param type
+     * @param handler
+     */
+    void addMessageHandler(MsgType type, MsgHandler handler);


[Checkstyle] 'method def modifier' has incorrect indentation level 4, expected level should be 2. (view)

Rule Severity

IndentationCheck warning

References:

https://checkstyle.org/config_misc.html#Indentation

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-13T02:04:47Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+    /**
+     * Send to an random peer
+     *
+     * @param out


[Checkstyle] At-clause should have a non-empty description. (view)

Rule Severity

NonEmptyAtclauseDescriptionCheck warning

References:

https://checkstyle.org/config_javadoc.html#NonEmptyAtclauseDescription

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-13T02:04:47Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+     * Send to an random peer
+     *
+     * @param out
+     * @param callback


[Checkstyle] At-clause should have a non-empty description. (view)

Rule Severity

NonEmptyAtclauseDescriptionCheck warning

References:

https://checkstyle.org/config_javadoc.html#NonEmptyAtclauseDescription

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-13T02:04:47Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+     * @param out
+     * @param callback
+     */
+    void sendToRandom(Message out, ResponseCallback callback);


[Checkstyle] 'method def modifier' has incorrect indentation level 4, expected level should be 2. (view)

Rule Severity

IndentationCheck warning

References:

https://checkstyle.org/config_misc.html#Indentation

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-13T02:04:47Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+     */
+    void sendToRandom(Message out, ResponseCallback callback);
+
+    /**


[Checkstyle] First sentence of Javadoc is missing an ending period. (view)

Rule Severity

SummaryJavadocCheck warning

References:

https://checkstyle.org/config_javadoc.html#SummaryJavadoc

You can close this issue if no need to fix it. Learn more.

ghost · 2020-07-13T02:04:48Z

src/main/java/org/fisco/bcos/sdk/channel/Channel.java

+     *
+     * @return List of connection information
+     */
+    List<ConnectionInfo> getConnectionInfo();


[Checkstyle] 'method def modifier' has incorrect indentation level 4, expected level should be 2. (view)

Rule Severity

IndentationCheck warning

References:

https://checkstyle.org/config_misc.html#Indentation

You can close this issue if no need to fix it. Learn more.

* <fix>(build): update dependencies version, add UT with AI. * Add unit tests to increase JaCoCo coverage from 30.1% to 30.7% (#1) * Initial plan * Initial setup: Upgrade Gradle to 7.6.4 for Java 17 compatibility and fix duplicate resources handling Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Add unit tests for model classes and exceptions to improve coverage Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Add more unit tests for model and enum classes to increase coverage Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Add unit tests for crypto exception classes to increase coverage Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Downgrade Gradle version to 6.3 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Add unit tests for SDK v3 client and transaction packages (#2) * Initial plan * Add unit tests for client and transaction packages - part 1 Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Add more unit tests for client protocol response and transaction dto classes Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Add unit tests for LogFilterRequest, model BO classes and CommonConstant Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Fix ResultCodeEnumTest to avoid mutating enum state in tests Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * <fix>(test): fixed tests path. * Add comprehensive test coverage for uncovered utility, protocol, and codec classes (#4) * Initial plan * Add comprehensive tests for ByteUtils, ThreadPoolService, SystemInformation, SecureRandomUtils, and LinuxSecureRandom Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Add comprehensive tests for JsonRpcRequest and TopicTools Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Address code review feedback - fix resource cleanup and remove redundant tests Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * <fix>(CI): fix windows ci version to 2025. * <fix>(build): update publish url to central.sonatype. --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

MaggieNgWu added 2 commits July 10, 2020 20:28

Add interface of channel and network

ca6900b

add interface of network module and channel module

987d5ad

MaggieNgWu requested review from cyjseagull and wheatli July 10, 2020 12:49

ghost reviewed Jul 10, 2020

View reviewed changes

MaggieNgWu added 2 commits July 12, 2020 23:14

add amop,client,eventsub interface

064237b

format code

c4640bd

ghost reviewed Jul 13, 2020

View reviewed changes

MaggieNgWu closed this Jul 13, 2020

Define interfaces of the network module and channel module. #4

Define interfaces of the network module and channel module. #4

Uh oh!

Conversation

MaggieNgWu commented Jul 10, 2020

Uh oh!

ghost commented Jul 10, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jul 13, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ghost commented Jul 10, 2020 •

edited by ghost

Loading