Evaluate Docker Compose for local development environment instead of shell script #36
Assignees
Labels
good first issue
Good for newcomers
help wanted
Extra attention is needed
improvement
Improves on something that already exists
Comments
jwflory
added
improvement
ghost
changed the title
This was referenced Nov 5, 2019
jwflory
added a commit
that referenced
this issue
Feb 17, 2020
This commit drops the old `start_devel_env.sh` script in favor of a more versatile `build.sh` script. This takes inspiration from tooling written for the Fedora Docs project in using different container runtimes based on what the user has installed to build a site (e.g. Docker or Podman). I considered using Docker Compose for this, but I think the future of rootless containers makes Docker Compose less interesting of a tool choice, because it is locked into the Docker container runtime. This script still uses Docker on macOS and Linux, but it also provides the possibility to use other container runtimes like Podman on Linux. Thus, I think this reworking of the dev environment build script is enough to close out issue #36. Note this commit does not update the docs, but this content will be moved to the Runbook instead of this repo. This is being tracked in #86. Closes #36. Signed-off-by: Justin W. Flory <git@jwf.io>
jwflory
added a commit
that referenced
this issue
Feb 20, 2020
This commit drops the old `start_devel_env.sh` script in favor of a more versatile `build.sh` script. This takes inspiration from tooling written for the Fedora Docs project in using different container runtimes based on what the user has installed to build a site (e.g. Docker or Podman). I considered using Docker Compose for this, but I think the future of rootless containers makes Docker Compose less interesting of a tool choice, because it is locked into the Docker container runtime. This script still uses Docker on macOS and Linux, but it also provides the possibility to use other container runtimes like Podman on Linux. Thus, I think this reworking of the dev environment build script is enough to close out issue #36. Note this commit does not update the docs, but this content will be moved to the Runbook instead of this repo. This is being tracked in #86. Closes #36. Signed-off-by: Justin W. Flory <git@jwf.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@Nolski mentioned idea of using Docker Compose instead of the shell script introduced in #35. It would be a cleaner way of managing the development environment. Given my previous experience with it in other projects, I think it would be a nice change.
I'm filing this for consideration in a post-v1.0 pull request. If someone has time and wants to play with this, feel free to try taking this one on!
The text was updated successfully, but these errors were encountered: