Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development environment instructions (closes #19) #35

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

jwflory
Copy link
Member

@jwflory jwflory commented Dec 2, 2018

This pull request adds new documentation to explain how to create a development environment to build and preview the fossrit.github.io website locally.

I tagged a few people for review because I'd like feedback to improve these instructions. By following the below instructions, you should be able to run a local development instance of the fossrit.github.io website. It should only take executing a script. If you have Docker already installed, it should "Just Work™".

Could anyone actually try this and let me know if it works easily for them? Is anything confusing or could it be better explained?

@jwflory jwflory added help wanted Extra attention is needed new change Adds new capabilities or functionality documentation Improvements or additions to documentation labels Dec 2, 2018
@jwflory jwflory added this to the v1.0 - public launch milestone Dec 2, 2018
@jwflory jwflory self-assigned this Dec 2, 2018
Copy link
Contributor

@Nolski Nolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Personally I'd advocate using docker-compose instead of a self written shell script for this case though

Copy link
Member

@Tjzabel Tjzabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Since I have a relatively fresh install of Fedora 29, I didn't have docker yet. I can verify the contributing instructions work from downloading docker to running the script and viewing the development site on http://localhost:4000.

.github/CONTRIBUTING.md Show resolved Hide resolved
@thenaterhood
Copy link
Member

thenaterhood commented Dec 2, 2018 via email

Copy link
Member

@jrtechs jrtechs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the docker deployment and how it automatically regenerates the source. We should definitely add this to the RITlug jekyll site.

I think we should also include the instructions for deploying this normally through Ruby since it allows us to run RSpec and it is slightly faster on older hardware.

@ghost
Copy link

ghost commented Dec 3, 2018 via email

@jwflory
Copy link
Member Author

jwflory commented Dec 3, 2018

@jrtechs:
I really like the docker deployment and how it automatically regenerates the source. We should definitely add this to the RITlug jekyll site.

Thanks. I can work on upstreaming it when I get Travis CI support for testing the website with the Docker container.

@jrtechs:
I think we should also include the instructions for deploying this normally through Ruby since it allows us to run RSpec and it is slightly faster on older hardware.

@ritjoe:
I'd be happy to see that and might be in a better place to use that and give feedback than the docker install.

This makes sense. I am uncertain if I can do this in a timely manner though because I do not want to install the dependencies on bare metal. Is this something either of you would be interested in contributing?

@jrtechs
Copy link
Member

jrtechs commented Dec 3, 2018

@jwflory I'd love to document how to run it without docker. I'll probably get around to it tomorrow afternoon.

@ghost
Copy link

ghost commented Dec 6, 2018 via email

@ghost
Copy link

ghost commented Dec 6, 2018 via email

@ghost
Copy link

ghost commented Dec 6, 2018 via email

jwflory added a commit that referenced this pull request Jan 4, 2019
@jwflory
Copy link
Member Author

jwflory commented Jan 4, 2019

I addressed @ritjoe's feedback in commit b9749e7. I'm merging this into the repo now. Thanks everyone for taking a look at this PR! 🎉

@jwflory jwflory merged commit 54f4459 into master Jan 4, 2019
@jwflory jwflory deleted the add/contributing-docs-19 branch January 4, 2019 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed new change Adds new capabilities or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants