Add readers for XSRG and CSRG #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NebelNidas
force-pushed
the
xsrg-and-csrg
branch
from
7a40f71 to
689c0c7
Compare
Also fixes SRG reader never visiting descs
NebelNidas
force-pushed
the
xsrg-and-csrg
branch
from
689c0c7 to
daf7dc0
Compare
|
Actually I don't think CSRG should be able to have holes, I'll have to add an explicit check to throw an exception if that's the case |
modmuss50
approved these changes
Oct 11, 2023
NebelNidas
added a commit
to NebelNidas/mapping-io
that referenced
this pull request
Nov 7, 2023
* Add support for XSRG and CSRG formats Also fixes SRG reader never visiting descs * Support and test mappings with dst name holes * Fix XSRG detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just modifications to the existing SRG and TSRG readers.
Closes #39 and closes #44.