All transition level types are moved to next biome

[A2ur3]

Disclaimers

• I have searched the issue tracker to check if the issue has already been reported.
• My issue happened while using mods.

What happened?

in the past, ColdCavernsTransition is one of Cold Caverns level types but now it is biomes="europanridge"
this means you can keep encountering transition level type even in late biome 2 because it does not have maxleveldifficulty
all other transition level types have the same issue
it causes ice chunks and spires appear in Hydrothermal Wastes (greatseatransition level type)
it breaks "Caverns Transition" monster EventSet because the eventset requires ColdCavernsTransition level type and has maxleveldifficulty="15" (ColdCavernsTransition level type can only appear in biome 2 where level difficulty is already greater than 15)

Reproduction steps

check xml files

Bug prevalence

Just once

Single player or multiplayer?

Single player

-

No response

Version

v1.8.8.1 (Calm Before the Storm Hotfix 2)

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

[Regalis11]

Thank you for the report!

Are you actually sure the levels appear further in the biome? The TransitionFromPreviousBiome attribute should force the level type to only be used in the "transition levels" between biomes. I also went through a handful of campaign maps, and couldn't find any misplaced levels.

Do you by any chance have campaign saves or seeds with that sort of misplaced levels?

[A2ur3]

Sorry, I drew a conclusion without fully checking the XML and testing. The TransitionFromPreviousBiome attribute does seem to restrict the transition level type to the connection between two biomes
This change also didn't break the event set, because the difficulty at the connection between the first biome and the second biome is 15
The issue can be closed now, sorry for the confusion...
This change is quite good 👍 previously, transition levels would repeatedly appear due to the World hostility setting (in hell difficulty, the entire first biome have 14.9% difficulty)