Update ion-java dep to 1.11.1 (from 1.11.10)
#622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaurya0108
changed the title
LONG instead of BIG INTEGER
Shaurya0108
changed the title
LONG instead of BIG INTEGERtestLongAsBigIntegerSize to use LONG instead of BIG INTEGER
cowtowncoder
changed the title
testLongAsBigIntegerSize to use LONG instead of BIG INTEGERion-java dep to 1.11.1 (from 1.11.10)
|
@cowtowncoder would a release to 2.18 be possible? We are currently using 2.18.4 at Ion, and will not be able to move to versions 2.19 and greater for a bit. |
|
@Shaurya0108 Hmmh. Normally I would say no but... 2.18 is the first LTS version of Jackson and it seems like a small patch upgrade. So perhaps. In the meantime I think you should be able to just override |
|
I am thinking of possibly releasing 2.18.5 today, but we will see how timing goes (if I have time to do it). |
|
Thank you for taking the time to do so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ion v1.11.11 (release notes) changed how values that fit in long are now classified (change in Ion Java), instead of using
BIG INTEGERthey useLONG. Using aBIG INTEGERwas causing testtestLongAsBigIntegerSizeto fail when the Ion version was changed to v1.11.11 from v1.11.10:The current version of Ion Java utilizes Jackson-dataformat-ion 2.18.