Skip to content

Conversation

@fushar
Copy link
Contributor

@fushar fushar commented Aug 9, 2015

  • asContainerSchema -> asContainerTypeSchema
  • asValueSchemaSchema -> asValueTypeSchema

The old methods are marked as deprecated.

@cowtowncoder
Copy link
Member

Sounds reasonable, but I will need to wait until master becomes 2.7; this change can not be made in patch version.
Two improvement suggestions:

  1. Add @since 2.7 in javadocs for new methods; and a note in @deprecated similarly that deprecation occurred in 2.7
  2. Make deprecated methods call the new methods, instead of directly returning. This helps old code with overrides to possibly work.

- asContainerSchema -> asContainerTypeSchema
- asValueSchemaSchema -> asValueTypeSchema

The old methods are marked as deprecated.
@fushar
Copy link
Contributor Author

fushar commented Aug 10, 2015

No problem.

Applied your suggestions.

cowtowncoder added a commit that referenced this pull request Sep 23, 2015
Fix typos in JsonSchema's methods
@cowtowncoder cowtowncoder merged commit 720b331 into FasterXML:master Sep 23, 2015
@fushar fushar deleted the fix-jsonSchema-typos branch March 5, 2016 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants