Skip to content

Upgrade to JUnit5 #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Dec 8, 2024
Merged

Upgrade to JUnit5 #866

merged 35 commits into from
Dec 8, 2024

Conversation

@k163377
Copy link
Contributor

@k163377 k163377 commented Dec 8, 2024

Since databind has been migrated to JUnit5, we will do the same for kotlin-module.
For the migration, I referred to the code of kogera which has already been migrated.
https://github.com/ProjectMapK/jackson-module-kogera

k163377 added 30 commits December 8, 2024 15:50
@k163377
Upgrade to JUnit5
dee7e97
@k163377
Replace @test(expected = ... with assertThorws
9a6ceb3
@k163377
Replace kotlin.test.Test with org.junit.jupiter.api.Test
4611f22
@k163377
Replace @rule with assertThrows
c27440c 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/ecc766d97dc4c2bec574fba7cc6bdeacc2b07c29/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zPorted/test/github/Github32.kt
@k163377
Replace @rule with assertThrows
5f5beec 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/ecc766d97dc4c2bec574fba7cc6bdeacc2b07c29/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zPorted/test/github/Github42.kt
@k163377
Remove use of @before
874cbde
@k163377
Migrate to JUnit5 notation and remove use of @ignore
4d267fc
@k163377
Migrate to JUnit5 notation and remove use of @ignore
de55aad 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/1ee3d47dd63f4cb1a9ef625bd16a7f56013258c4/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zIntegration/deser/valueClass/WithoutCustomDeserializeMethodTest.kt
@k163377
Migrate to JUnit5 notation and remove use of @ignore
bdff599 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/ecc766d97dc4c2bec574fba7cc6bdeacc2b07c29/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zPorted/test/github/failing/GitHub337.kt
@k163377
Remove use of @ignore
56ffadc
@k163377
Migrate to JUnit5 notation
277ae27 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/7872116052c9a4744c6d4e84ddd5cab6bb525024/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zIntegration/deser/VarargTest.kt
@k163377
Migrate to JUnit5 notation
398387e
@k163377
Migrate to JUnit5 notation
b36abe1 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/b2bdb6abca5ac95143c6e35eecfd5d499750705d/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zIntegration/deser/valueClass/deserializer/SpecifiedForObjectMapperTest.kt
@k163377
Migrate to JUnit5 notation
822d654 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/b2bdb6abca5ac95143c6e35eecfd5d499750705d/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zIntegration/deser/valueClass/deserializer/byAnnotation/specifiedForProperty
@k163377
Replace org.junit.Test with org.junit.jupiter.api.Test
5a199ee
@k163377
Migrate to JUnit5 notation
93f230f
@k163377
Replace org.junit.Assert with org.junit.jupiter.api.Assertions
722c37b
@k163377
Migrate to JUnit5 notation
5ff39e7 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/22eda81dcf38af00a81b58de15fb86a73e5c2715/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/JDKSerializabilityTestHelper.kt
@k163377
Migrate to JUnit5 notation
d4070a7 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/ecc766d97dc4c2bec574fba7cc6bdeacc2b07c29/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zPorted/test/ExtensionMethodsTests.kt
@k163377
Replace junit.framework.TestCase with org.junit.jupiter.api.Assertions
b8931e8
@k163377
Migrate to JUnit5 notation
c695766
@k163377
Migrate to JUnit5 notation
1e881c8 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/ecc766d97dc4c2bec574fba7cc6bdeacc2b07c29/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zPorted/test/KotlinBuiltinsTest.kt
@k163377
Migrate to JUnit5 notation
52ae8cf 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/ecc766d97dc4c2bec574fba7cc6bdeacc2b07c29/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zPorted/test/github/Github490.kt
@k163377
Migrate to JUnit5 notation
0777195 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/ecc766d97dc4c2bec574fba7cc6bdeacc2b07c29/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zPorted/test/github/Github27.kt
@k163377
Migrate to JUnit5 notation
cabf39d 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/ecc766d97dc4c2bec574fba7cc6bdeacc2b07c29/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zPorted/test/KotlinFeatures.kt
@k163377
Migrate to JUnit5 notation
11e42dd 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/ecc766d97dc4c2bec574fba7cc6bdeacc2b07c29/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zPorted/test/ParameterNameTests.kt
@k163377
Migrate to JUnit5 notation
0a39f2f 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/ecc766d97dc4c2bec574fba7cc6bdeacc2b07c29/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zPorted/test/ObjectSingletonTest.kt
@k163377
Migrate to JUnit5 notation
881722f 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/ecc766d97dc4c2bec574fba7cc6bdeacc2b07c29/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zPorted/test/UnsignedNumbersTests.kt
@k163377
Migrate to JUnit5 notation
98b3e6f
@k163377
Migrate to JUnit5 notation
b5c8d4d 
from https://github.com/ProjectMapK/jackson-module-kogera/blob/ecc766d97dc4c2bec574fba7cc6bdeacc2b07c29/src/test/kotlin/io/github/projectmapk/jackson/module/kogera/zPorted/test/github/Github52.kt
@k163377
Copy link
Contributor Author

k163377 commented Dec 8, 2024

@cowtowncoder
Just to be sure, I will share the changes.

@k163377 k163377 merged commit 2ee6fe9 into FasterXML:2.19 Dec 8, 2024
15 checks passed
@k163377 k163377 deleted the junit5 branch December 8, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@k163377