Skip to content
This repository was archived by the owner on Feb 21, 2024. It is now read-only.

Build target also builds fbsql, fbsql is also packaged. #2260

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Build target also builds fbsql, fbsql is also packaged. #2260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f75590f
Build target also builds fbsql, fbsql is also packaged.
Feb 17, 2023
0d77c0e
Merge branch 'master' into package-fbsql
Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ cover-viz: cover
# Compile Pilosa
build:
$(GO) build -tags='$(BUILD_TAGS)' -ldflags $(LDFLAGS) $(FLAGS) ./cmd/featurebase
$(GO) build -tags='$(BUILD_TAGS)' -ldflags $(LDFLAGS) $(FLAGS) ./cmd/fbsql
Copy link
Author

@j3m7 j3m7 Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrwalker

What would happen in Cloud if this fbsql wasn't built and packaged?

The packaging process would fail, this adds the fbsql executable as part of the make target so it's built every time CI builds the DB



package:
GOOS=$(GOOS) GOARCH=$(GOARCH) FLAGS="-o featurebase" $(MAKE) build
Expand Down
4 changes: 3 additions & 1 deletion nfpm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ homepage: "https://molecula.com"
contents:
- src: ./featurebase
dst: /usr/bin/featurebase
- src: ./fbsql
dst: /usr/bin/fbsql
- src: ./install/featurebase.conf
dst: /etc/featurebase/featurebase.conf
type: config|noreplace
Expand All @@ -22,7 +24,7 @@ contents:
- src: ./install/featurebase.debian.service
dst: /lib/systemd/system/featurebase.service
packager: deb
- dst: /var/log/molecula # We use vendor name on log directory in case other molecula components need it.
- dst: /var/log/molecula # We use vendor name on log directory in case other molecula components need it.
type: dir
file_info:
mode: 0755
Expand Down