-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Prettier as a formatter (and format everything) #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were not mentioned anywhere else else in the code after doing a quick grep. The format was going to bug out the Prettier formatting, so I have made the decision to remove them instead of adding an ignore on files that are not beign used.
Replaces quotations and does basic indentation that is trivial. This is separate as the other will make more changes for files that are actual code.
Formats all the general js files. Separate in case these should be treated differently for any reason. This commit includes all javascript and HTML files.
Lints the README. Separate commit as it does a lot of reflowing.
Lints CSS files from this repo. This does NOT affect minimized css via the ignore file.
Fixed a bunch of style related fixes and formatting errors due caused by incorrect code block languages
Fixed all the strange inline code endings
Added some space between lists and their modifiers
Styles at the bottom removed
Added space before the modifiers
Fixes some modifier spacing
Fixes the modifier spacing
fixed bitwise OR operators for the tables
Fixed the blank spaces as well as broken dropdowns
Fixed bitwise opreators and modifier spacing
Fixes the spacing and tabel formatting
Fixed a single letter of capitalization
Fixed modifier spacing and comment image
Fix modifier spacing and a little capitalization
Fix the basics of the Django page. This needs a full rewrite in the future, however this fixes some of the most glaring issues.
Fixed modifier spacing
Added ignores to some code blocks and fixed up the table code block formatting
Fixes table alignment and shows table headers for tables at the top of thier card
Fixes table alighment and other formatting things. Table align right may be a bad user experience
This is included as it is part of the format but also would have caused merge conflicts if it was in a separate commit.
Added code wrappers to all selectors for consistency
Removes the larger text size, as that makes the page significantly less readable due to line height.
Fixed the modifier spacing (wow)
Fixed the modifier spacing
Fixed a small capitalization and the class modifier things
Fixes the bullets and modifier spacing
Changes the only section to be two columns
Fixed the tables
Fixes the layout of the boxes to fit a little better
Fixes formatting, aligns tables, and adds some more highlighitng to go in with the current yellow highlights
Fixed the modifier spacing
Fixed the table issue as well
Fixes the classic code block with | symbol issue
Changes it to be 2 columns
Fixed the table with pipe issue again
Adds some row span to make it more compact and fixes a small spelling error
fixes a small spelling error
Changes format to 2 columns
Fixed modifier spacing (wow again)
Fixed minor spelling error
Fixed some broken formatting and misused header levels
Changed to be 2 columns
Fixes the tables
Fixed the Mac icons
Fixed the table having a random space
Added some ignores
Every other file's format which was automatically converted correctly. Each has been manually checked and they should all be visually the same.
Fixed some random space and misspellings
Owner
|
@FireIsGood, Thank you very much for your extensive and for taking the initiative to add prettier and format our project! It's impressive to see the diligence with which you've manually reviewed each file and fixed errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #526
Adds prettier and formats everything applicable. There are also some assorted format fixes manually added as part of checking every single page.
Every post has been manually looked through for errors and corrected.
Before
One of many, many examples:
After
After formatting
(I had to manually fix a lot of tables)
Some files like minimized CSS and the
fuze.jsfile have been ignored.