Conversation
Signed-off-by: İlyas Akın <ashnwor@gmail.com>
| } | ||
|
|
||
| &_main_active { | ||
| background-color: #ffffff; |
There was a problem hiding this comment.
All colors value must set from the css variables. This need for correctly works of themes.
There was a problem hiding this comment.
For bg uses var(--bg-tab)
There was a problem hiding this comment.
This one needs to use seperate css variable rather than a common variable that effects all tabs. Because only main button turns white when active.
Should I create one?
There was a problem hiding this comment.
I think the main button shouldn't change color on white, it just accept color such as bg color of a current web page. In the official desktop app case , the button change active bg color on bg color of the projects browser page.
I our case, the main button should changes own bg color on bg color of project browser too, but given current theme
There was a problem hiding this comment.
Well, I did that on last commit. Works for all themes without need to edit them. But the problem is it inverts the color (for icon contrast) and it can lead to some unintended ugly color combinations (Check purple and blue theme for example). I think we need a new variable like var(--fg-tab-main-active).
If it's ok I will add var(--fg-tab-main-active) and open a PR on https://github.com/Figma-Linux/figma-linux-themes/ for corresponding changes.
There was a problem hiding this comment.
No needed add the new css variable, maybe just need will update themes in the themes repository
|
|
||
| &:hover { | ||
| cursor: default; | ||
| background-color: #ffffff; |
There was a problem hiding this comment.
var(--bg-tab-hover)
| &:hover { | ||
| cursor: default; | ||
| background-color: #ffffff; | ||
| color: #000000; |
There was a problem hiding this comment.
var(--fg-tab-hover)
|
Can you also make the titlebar inline like that of firefox or chrome so that it looks native and consume less space at top, like that on windows |
The titlebar already look nearly as titlebar from official desktop app |
3 participants
This PR;
Feel free to roast the code.