Skip to content

Add support for OSC 1.1 tags#23

Merged
ChrisAshworth merged 3 commits intomasterfrom
18-osc-1.1-tags
Feb 20, 2020
Merged

Add support for OSC 1.1 tags#23
ChrisAshworth merged 3 commits intomasterfrom
18-osc-1.1-tags

Conversation

@balord
Copy link
Copy Markdown
Contributor

@balord balord commented Feb 19, 2020

  • Add support for sending and receiving OSC 1.1 tags T, F, N, and I
  • Add support for text-to-OSC of these tags in the form of backslash-escaped \T, \F, \N, and \I
  • Update F53OSCMessageTests with the new tags
  • Add F53OSC_NSNumberTests to verify our assumptions about internal storage of NSNumber

Closes #18

- Update F53OSCMessageTests with new tags

Closes #18
Comment thread F53OSCMessage.m Outdated
@ChrisAshworth ChrisAshworth mentioned this pull request Feb 19, 2020
- Rather than banking on the uncertain internal workings of NSNumber
- where the other category imports live
- move `F53OSCFoundationAdditions.h` import to the F53OSCMessage header, since we want the NSValue convenience methods available to anyone who imports F53OSCMessage
@ChrisAshworth ChrisAshworth merged commit 7919e2b into master Feb 20, 2020
@ChrisAshworth ChrisAshworth deleted the 18-osc-1.1-tags branch February 20, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parser doesn't parse T or F arguments

3 participants