fix(storage): trim provider resolver & pass all erorrs through

[rvagg]

validateDataSet is mostly redundant here because getClientDataSets already applies roughly the same filters so it's primarily acting as an invariant (i.e. does PDPVerifier agree that this is still active and managed by FWSS?). So we can remove one RPC call per data set and it's the call that can throw, so all other errors that come from these RPC calls are going to be problems for the user to deal with (such as RPC rate limit errors).

validateDataSet throwing here is one of those "throw == false" situations, but of course we're not doing any sophisticated checking here and swalling any other kind of error, including RPC. The theory behind not being strict is something like: it's not critical that we find a matching data set, it's more critical that we get the user's data uploaded. But in the case of dealbot which is trying to be precise, that falls apart and our user in that case doesn't want any laxity.

[rvagg]

The other instances of validateDataSet in here are still reasonable, one is resovleByDataSetId and we do want to check that it's both active and managed by FWSS, and the other is in commit() which is acting like a final "this is going to work, right?", in both of those cases the error will be returned.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
❌ Deployment failed View logs	synapse-dev	6fe56be	Mar 30 2026, 03:28 AM