refactor(client)!: switch query params objects to use QueryParams
#369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(client): add methods for removing additional properties chore(internal): remove unnecessary validation methods chore(internal): swap params body getters to use optionals chore(internal): remove unnecessary nullable annotations style(internal): minor changes to code ordering and syntax # Migration If you were accessing `_additionalProperties()` on a query params object, then previously it returned `Map<String, List<String>>`. Now it returns a dedicated `QueryParams` object. The `QueryParams` class is better suited for mapping a key to multiple values and has similar methods to `Map`.
stainless-app bot
added a commit
that referenced
this pull request
Jan 2, 2025
…369) feat(client): add methods for removing additional properties chore(internal): remove unnecessary validation methods chore(internal): swap params body getters to use optionals chore(internal): remove unnecessary nullable annotations style(internal): minor changes to code ordering and syntax # Migration If you were accessing `_additionalProperties()` on a query params object, then previously it returned `Map<String, List<String>>`. Now it returns a dedicated `QueryParams` object. The `QueryParams` class is better suited for mapping a key to multiple values and has similar methods to `Map`.
Merged
stainless-app bot
added a commit
that referenced
this pull request
Jan 7, 2025
…369) feat(client): add methods for removing additional properties chore(internal): remove unnecessary validation methods chore(internal): swap params body getters to use optionals chore(internal): remove unnecessary nullable annotations style(internal): minor changes to code ordering and syntax # Migration If you were accessing `_additionalProperties()` on a query params object, then previously it returned `Map<String, List<String>>`. Now it returns a dedicated `QueryParams` object. The `QueryParams` class is better suited for mapping a key to multiple values and has similar methods to `Map`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(client): add methods for removing additional properties
chore(internal): remove unnecessary validation methods
chore(internal): swap params body getters to use optionals
chore(internal): remove unnecessary nullable annotations
style(internal): minor changes to code ordering and syntax
Migration
If you were accessing
_additionalProperties()on a query params object, then previously it returnedMap<String, List<String>>. Now it returns a dedicatedQueryParamsobject. TheQueryParamsclass is better suited for mapping a key to multiple values and has similar methods toMap.