Revert call to check nextjs version #446

annajowang · 2025-12-04T00:00:57Z

Reverts #445

This reverts commit f1bd8d6.

gemini-code-assist · 2025-12-04T00:01:13Z

Summary of Changes

Hello @annajowang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a full revert of a previous change (PR #445) that altered the semantic versioning operator used for Next.js version compatibility checks. The revert restores the ^ (caret) operator, which allows for minor version updates, instead of the ~ (tilde) operator, which is more restrictive. Additionally, the associated package version for the Next.js adapter is downgraded, and related test cases are removed to align with the reverted logic.

Highlights

Revert of Version Specifier Change: The primary change is reverting the use of the ~ (tilde) operator back to ^ (caret) for Next.js version checking in SAFE_NEXTJS_VERSIONS.
Package Version Downgrade: The @apphosting/adapter-nextjs package version is reverted from 14.0.19 to 14.0.18 in both package.json and package-lock.json.
Test Case Removal: Specific test cases related to Next.js versions 15.4.7 and 15.4.8 are removed from utils.spec.ts.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request reverts a previous change (#445), which had switched the semver matching for Next.js versions from ^ to ~. The changes in this PR correctly revert the package versions, the version matching string, and the associated tests. My review includes one minor suggestion to improve the readability of an error message.

gemini-code-assist · 2025-12-04T00:02:37Z

packages/@apphosting/adapter-nextjs/src/utils.ts

  if (!satisfies(version, SAFE_NEXTJS_VERSIONS)) {
    throw new Error(
-      `CVE-2025-55182: Vulnerable Next version ${version} detected. Deployment blocked. Update your app's dependencies to a patched Next.js version and redeploy: https://nextjs.org/blog/CVE-2025-66478#fixed-versions`,
+      `CVE-2025-55182: Vulnerable Next version ${version} detected. Deployment blocked. Update your app's dependencies to a patched Next.js version and redeploy:https://nextjs.org/blog/CVE-2025-66478#fixed-versions`,


For improved readability, a space should be added before the URL in this error message.

Suggested change

`CVE-2025-55182: Vulnerable Next version ${version} detected. Deployment blocked. Update your app's dependencies to a patched Next.js version and redeploy:https://nextjs.org/blog/CVE-2025-66478#fixed-versions`,

`CVE-2025-55182: Vulnerable Next version ${version} detected. Deployment blocked. Update your app's dependencies to a patched Next.js version and redeploy: https://nextjs.org/blog/CVE-2025-66478#fixed-versions`

taeold · 2025-12-04T00:02:24Z

packages/@apphosting/adapter-nextjs/package.json

 {
  "name": "@apphosting/adapter-nextjs",
-  "version": "14.0.19",
+  "version": "14.0.18",


This intentional?

taeold · 2025-12-04T00:03:37Z

packages/@apphosting/adapter-nextjs/src/utils.spec.ts

      checkNextJSVersion("15.0.5");
    });

-    assert.throws(() => {


Removing test intentional? Seems like correct tests.

taeold · 2025-12-04T00:04:12Z

packages/@apphosting/adapter-nextjs/src/utils.ts

  if (!satisfies(version, SAFE_NEXTJS_VERSIONS)) {
    throw new Error(
-      `CVE-2025-55182: Vulnerable Next version ${version} detected. Deployment blocked. Update your app's dependencies to a patched Next.js version and redeploy: https://nextjs.org/blog/CVE-2025-66478#fixed-versions`,
+      `CVE-2025-55182: Vulnerable Next version ${version} detected. Deployment blocked. Update your app's dependencies to a patched Next.js version and redeploy:https://nextjs.org/blog/CVE-2025-66478#fixed-versions`,


Just double checking you wanted this change too!

This reverts commit 71a239c.

* Revert "Revert call to check nextjs version (#446)" This reverts commit 71a239c. * npm install

Revert "Switch ^ to ~ in nextjs version checking string (#445)"

83e609c

This reverts commit f1bd8d6.

annajowang requested review from Yuangwang, blidd-google, jamesdaniels, leoortizz, sjjj986 and taeold as code owners December 4, 2025 00:00

gemini-code-assist bot reviewed Dec 4, 2025

View reviewed changes

Yuangwang approved these changes Dec 4, 2025

View reviewed changes

taeold approved these changes Dec 4, 2025

View reviewed changes

annajowang added 4 commits December 4, 2025 00:11

clean

ab6ba0d

version update

77458bf

npm install

d6b347c

update

3afed60

annajowang changed the title ~~Revert "Switch ^ to ~ in nextjs version checking string"~~ Remove call to check nextjs version Dec 4, 2025

revert everything

4c0b156

annajowang changed the title ~~Remove call to check nextjs version~~ Revert call to check nextjs version Dec 4, 2025

Remove semver

c4d83cd

annajowang merged commit 71a239c into main Dec 4, 2025
10 checks passed

annajowang deleted the revert-445-new-version branch December 4, 2025 18:27

annajowang added a commit that referenced this pull request Dec 4, 2025

Revert "Revert call to check nextjs version (#446)"

fcd4eea

This reverts commit 71a239c.

annajowang mentioned this pull request Dec 4, 2025

Block builds on vulnerable nextjs versions #447

Merged

annajowang added a commit that referenced this pull request Dec 4, 2025

Block builds on vulnerable nextjs versions (#447)

714b0e6

* Revert "Revert call to check nextjs version (#446)" This reverts commit 71a239c. * npm install

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert call to check nextjs version #446

Revert call to check nextjs version #446

Uh oh!

annajowang commented Dec 4, 2025

Uh oh!

gemini-code-assist bot commented Dec 4, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Dec 4, 2025

Uh oh!

taeold Dec 4, 2025

Uh oh!

taeold Dec 4, 2025

Uh oh!

taeold Dec 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	`CVE-2025-55182: Vulnerable Next version ${version} detected. Deployment blocked. Update your app's dependencies to a patched Next.js version and redeploy:https://nextjs.org/blog/CVE-2025-66478#fixed-versions`,
	`CVE-2025-55182: Vulnerable Next version ${version} detected. Deployment blocked. Update your app's dependencies to a patched Next.js version and redeploy: https://nextjs.org/blog/CVE-2025-66478#fixed-versions`

Revert call to check nextjs version #446

Revert call to check nextjs version #446

Uh oh!

Conversation

annajowang commented Dec 4, 2025

Uh oh!

gemini-code-assist bot commented Dec 4, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

taeold Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

taeold Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

taeold Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants