Don't use JS SDK private APIs. #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdaniels
commented
Mar 11, 2020
Collaborator
Author
jhuleatt
approved these changes
Mar 11, 2020
Collaborator
jhuleatt
left a comment
jhuleatt
left a comment
There was a problem hiding this comment.
Thanks James! Just a couple nits but LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't mind noise due to the recent linting changes.
No longer use the undocumented
queryIdentifiermethod andcannonicalIdproperty in RTDB and Firestore queries respectively. A) they're not stable B)cannonicalIddoesn't give us the properties we expect and C)._query.cannonicalIdis getting mangled in the minified Firestore builds #221. Instead we should be using the exposedisEqualmethod to compare.Now there is a break here, I needed to store these query caches globally & it's very important they work correctly across platforms. As such I decided to drop the flawed inline polyfill I already had for
globalThis. I've included a polyfill in our test suite but I'm not bundling it.We should communicate polyfills a developer might need in the docs. I will take a stab at that in this PR.