Update preload methods in sample #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuleatt
reviewed
May 5, 2020
| return firestore().enablePersistence(); | ||
| preloadFirestore({ | ||
| firebaseApp, | ||
| setup(firestore) { |
There was a problem hiding this comment.
any opinion on
setup(firestore) {vs
setup: firestore => {for all of these?
The second is a bit more clear to me, but that could just be me
There was a problem hiding this comment.
I prefer the named function. AFIK, it will show up in the stack trace and the arrow function will not.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sample app in the repository to use the latest API for
preloadFactory()methods: