Skip to content

Update preload methods in sample #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2020
Merged

Update preload methods in sample #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions sample/src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,20 +38,29 @@ const Card = ({ title, children }) => {
// fetching them now
const preloadSDKs = firebaseApp => {
return Promise.all([
preloadFirestore(firebaseApp, firestore => {
return firestore().enablePersistence();
preloadFirestore({
firebaseApp,
setup(firestore) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any opinion on

setup(firestore) {

vs

setup: firestore => {

for all of these?

The second is a bit more clear to me, but that could just be me

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the named function. AFIK, it will show up in the stack trace and the arrow function will not.

return firestore().enablePersistence();
}
}),
preloadDatabase(firebaseApp),
preloadStorage(firebaseApp, storage => {
storage().setMaxUploadRetryTime(10000);
preloadDatabase({ firebaseApp }),
preloadStorage({
firebaseApp,
setup(storage) {
return storage().setMaxUploadRetryTime(10000);
}
}),
preloadAuth(firebaseApp),
preloadRemoteConfig(firebaseApp, remoteConfig => {
remoteConfig().settings = {
minimumFetchIntervalMillis: 10000,
fetchTimeoutMillis: 10000
};
return remoteConfig().fetchAndActivate();
preloadAuth({ firebaseApp }),
preloadRemoteConfig({
firebaseApp,
setup(remoteConfig) {
remoteConfig().settings = {
minimumFetchIntervalMillis: 10000,
fetchTimeoutMillis: 10000
};
return remoteConfig().fetchAndActivate();
}
})
]);
};
Expand All @@ -60,10 +69,7 @@ const preloadData = async firebaseApp => {
const user = await preloadUser(firebaseApp);

if (user) {
preloadFirestoreDoc(
firestore => firestore.doc('count/counter'),
firebaseApp
);
preloadFirestoreDoc(firestore => firestore.doc('count/counter'), firebaseApp);
}
};

Expand Down